Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hypot #9823

Merged
merged 3 commits into from
Jan 19, 2023
Merged

hypot #9823

merged 3 commits into from
Jan 19, 2023

Conversation

vyvk
Copy link
Contributor

@vyvk vyvk commented Jan 18, 2023

Close #9624

@ivy-leaves ivy-leaves added Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API labels Jan 18, 2023
nassimberrada
nassimberrada suggested changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@nassimberrada nassimberrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vvk10, thank you for your contribution ! I think this looks mostly good, i just left a couple of comments maybe you could address those. Let me know when you're done and i'll be able to merge. Thanks !

ivy_tests/test_ivy/test_functional/test_experimental/test_core/test_elementwise.py Outdated Show resolved Hide resolved
ivy/container/experimental/elementwise.py Outdated Show resolved Hide resolved
@vyvk
Copy link
Contributor Author

vyvk commented Jan 19, 2023

Hi @nassimberrada, thanks for reviewing my PR. I have made changes as per your comments. Please review them.

@nassimberrada
Copy link
Contributor

Looks good to me, merging now. Thanks again for your contribution !

@nassimberrada nassimberrada merged commit e91399d into ivy-llc:master Jan 19, 2023
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 23, 2023
@vyvk
hypot (ivy-llc#9823)
f38c270 
* Added function hypot

* Corrected variable names and docstring
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 26, 2023
@vyvk
hypot (ivy-llc#9823)
f90ac39 
* Added function hypot

* Corrected variable names and docstring
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 26, 2023
@vyvk
hypot (ivy-llc#9823)
784047f 
* Added function hypot

* Corrected variable names and docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nassimberrada nassimberrada nassimberrada requested changes

Assignees

@nassimberrada nassimberrada

Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hypot
3 participants
@vyvk @nassimberrada @ivy-leaves