Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the frontend test of tf.math.argmax #9800

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Fixing the frontend test of tf.math.argmax #9800

merged 2 commits into from
Jan 19, 2023

Conversation

hello-fri-end
Copy link
Contributor

close #8036

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Jan 18, 2023
@WilliamHirst
Copy link
Contributor

Hi Anwaar,
Thank you for making a contribution.

I see that there is a formatting error in the commit. Check out the test-log for the details.

@hello-fri-end
Copy link
Contributor Author

Hi Anwaar, Thank you for making a contribution.
Hi @WilliamHirst !

I see that there is a formatting error in the commit. Check out the test-log for the details.

Thanks for the review! I have fixed the lint error. You can merge this now 🚀

@WilliamHirst WilliamHirst merged commit 7fbea68 into ivy-llc:master Jan 19, 2023
@WilliamHirst
Copy link
Contributor

Looks good! Merged 👍

vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 23, 2023
@hello-fri-end
Fixing the frontend test of tf.math.argmax (ivy-llc#9800)
2999375 
Co-authored-by: WilliamHirst [email protected]
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 26, 2023
@hello-fri-end
Fixing the frontend test of tf.math.argmax (ivy-llc#9800)
8bb74b6 
Co-authored-by: WilliamHirst [email protected]
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 26, 2023
@hello-fri-end
Fixing the frontend test of tf.math.argmax (ivy-llc#9800)
4f2f66d 
Co-authored-by: WilliamHirst [email protected]
@hello-fri-end hello-fri-end deleted the fixTFARGMAX branch March 15, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@WilliamHirst WilliamHirst

Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix math.test_tensorflow_argmax
3 participants
@hello-fri-end @WilliamHirst @ivy-leaves