Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ufunc class to the numpy frontend #9732

Merged
merged 13 commits into from
Jan 19, 2023
Merged

Conversation

fnhirwa
Copy link
Contributor

@fnhirwa fnhirwa commented Jan 16, 2023

Hey @fspyridakos

I finished the initial implementation of the np.ufunc class in the numpy frontend.
Waiting for your review after that we start calling the frontend functions that are instances of np.ufunc using ufunc(func_name).

With the implementation below I was able to implement some of a few class methods:

  • call()
  • nin()
  • not()
  • nargs()

With their unit tests along, other methods associated with this class can take time to implement as they are complex 🙂. I think we can make these methods open for contribution or work on them progressively.

Thanks😊

@fnhirwa fnhirwa self-assigned this Jan 16, 2023
@ivy-leaves ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Jan 16, 2023
@fspyridakos
Copy link
Contributor

Yup looks good, go ahead and start initialising the ufuncs in the main __init__, again we might need to rename the current function names to prevent name errors

@fspyridakos fspyridakos merged commit 3738447 into ivy-llc:master Jan 19, 2023
@fnhirwa fnhirwa deleted the ufunc branch January 20, 2023 13:07
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 23, 2023
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 26, 2023
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants