add floor divide #9516
Merged
add floor divide #9516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamjameskeane
suggested changes
Jan 10, 2023
There was a problem hiding this comment.
Hey,
Thanks for submitting this PR
The test for this PR didn't run properly, but in the meantime, there are lint errors in the files relevant to this PR, if you haven't already you can install a pre-commit hook to prevent these in the future here
Will get back when the test runs successfully!
Happy Coding :)
|
Hey James, Thanks for reviewing my PR. I believe the failing tests are not from my test cases. Running the tests locally (image below), I see that all 4 of them pass. I also fixed the lint errors. The current failed lint errors don't seem to be from any code that I have changed. Let me know if there's anything else I need to change.
|
iamjameskeane
approved these changes
Jan 19, 2023
vedpatwardhan
pushed a commit
to vedpatwardhan/ivy
that referenced
this pull request
Feb 23, 2023
Co-authored-by: jkeane508 <[email protected]>
vedpatwardhan
pushed a commit
to vedpatwardhan/ivy
that referenced
this pull request
Feb 26, 2023
Co-authored-by: jkeane508 <[email protected]>
vedpatwardhan
pushed a commit
to vedpatwardhan/ivy
that referenced
this pull request
Feb 26, 2023
Co-authored-by: jkeane508 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #9512