Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello! Don't we need to set 'myIterIn=nIter0' in mit_run.F ? #2

Open
ajinn05 opened this issue Jun 20, 2023 · 4 comments
Open

Hello! Don't we need to set 'myIterIn=nIter0' in mit_run.F ? #2

ajinn05 opened this issue Jun 20, 2023 · 4 comments

Comments

@ajinn05
Copy link

ajinn05 commented Jun 20, 2023

Hello Rui,

I had some difficulties while restarting the simulation with diagnostics package.
I can't restart the simulation whenever I use diagnostics package. The error messages were like below:
(PID.TID 0000.0001) *** DIAGNOSTICS_STATUS_ERROR *** from: DIAGNOSTICS_FILL call
(PID.TID 0000.0001) *** ERROR *** DIAGNOSTICS_FILL: diagName="ETAN ", expectStatus= 20, pkgStatus= 10
(PID.TID 0000.0001) *** ERROR *** DIAGNOSTICS_FILL: <== called from the WRONG place, i.e.
(PID.TID 0000.0001) *** ERROR *** DIAGNOSTICS_FILL: before DIAGNOSTICS_SWITCH_ONOFF call in FORWARD_STEP

This error was caused in subroutine DO_STATEVARS_DIAGS because of 'drag_pkgStatus != ready2fillDiags.'
The model did not set diag_pkgStatus = ready2fillDiags in subroutine DIAGNOSTICS_SWITCH_ONOFF since myIter != nIter0.

And I figured out I can solve this problem by changing some lines in mitCode/mit_run.F.
Since the problem was related to the nIter0 which is not zero for the restart case, I found that there's two lines commented out in 'mit_run.F':
173 ! myTimeIn=startTime
174 ! myIterIn=nIter0

So I just wonder if I have to comment out those lines, or it is okay to uncomment to solve the problem.

Best,
Ajin

@iurnus
Copy link
Owner

iurnus commented Jun 20, 2023 via email

@iurnus
Copy link
Owner

iurnus commented Jun 20, 2023 via email

@ajinn05
Copy link
Author

ajinn05 commented Jun 20, 2023

Hi Rui,

I agree that the way you mentioned above will solve this issue because it was working when I tested with nIter0=0 using pickup files.
But I should update data.cal every restart for that case, right?

Also, I tested my simulation with nTimeSteps instead of nEndIter.
And it is still not working..
Should I check other things?

Best,
Ajin

@iurnus
Copy link
Owner

iurnus commented Jun 20, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants