Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source to nuget packages #179

Open
xivk opened this issue Apr 18, 2018 · 7 comments
Open

Add source to nuget packages #179

xivk opened this issue Apr 18, 2018 · 7 comments
Assignees
Milestone

Comments

@xivk
Copy link
Contributor

xivk commented Apr 18, 2018

Figure out how to add the source to the nuget packages or how to use some other way to enable package consumers to step through the code use to build.

@xivk xivk added this to the Itinero 1.4 milestone Apr 18, 2018
@xivk xivk self-assigned this Apr 18, 2018
@JoeCooper
Copy link
Contributor

Have you already looked into this?

What I'm seeing is one needs a "symbol package".

https://docs.microsoft.com/en-us/nuget/create-packages/symbol-packages

@xivk
Copy link
Contributor Author

xivk commented May 4, 2018

I searched a bit and didn't really find a solution that would work cross-platform and as seamless as I would like it to work. The issues I have with the solutions I found is that consumers of the packages have to explicitly take action to able to see the source. I was hoping there was a better solution.

I wouldn't mind including the source with the nugets if consumers could somehow step through them.

Also: It wouldn't be the end of the world if this didn't make it into 1.4, I was hoping for an easy fix for this.

@xivk
Copy link
Contributor Author

xivk commented May 5, 2018

This may also be relevant here:

https://github.com/dotnet/sourcelink

@JoeCooper
Copy link
Contributor

I'm going to try this and see what it does.

@xivk
Copy link
Contributor Author

xivk commented Jun 6, 2018

@JoeCooper Did you manage to look at sourcelink? does that look like something we could use here?

@JoeCooper
Copy link
Contributor

Hey, sorry. I had to jump off this project and onto another client for a bit. I'm drowning in work at the moment :/

@xivk
Copy link
Contributor Author

xivk commented Jun 15, 2018

This is interesting and relevant here:

https://twitter.com/KirillOsenkov/status/1007052524946255872?s=19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants