Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception handling #49

Merged
merged 13 commits into from
Jan 25, 2018
Merged

Exception handling #49

merged 13 commits into from
Jan 25, 2018

Conversation

fottavi
Copy link
Collaborator

@fottavi fottavi commented Jan 18, 2018

Many changes also on this PR:

  • Switched from VS2015 to VS2017 Community
  • Changed setup system to NSIS script
  • Better use of exceptions, based on std::exception. RESULT type is no more used, so function signatures are easier to read/use.
  • Removed many ugly macros for function body header/footer, windows calls, PCSC calls, Smart card calls, asserts
  • Now the minidriver works also on Microsoft Edge. The App Container SID is added to the ACL (read only) of cache folder.
  • All c++ standard types are used where possible (BYTE -> uint8_t, WORD -> uint16_t, DWORD -> uint32_t)

Things to do:

  • Fix appveyor to compile on VS2017 (thanks @alexrj!!)
  • Change logging system to a better, standard and simple one. This could work?

Copy link
Member

@alranel alranel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All nice things, thumbs up from me!
(I didn't do a line-by-line review though)

@alranel
Copy link
Member

alranel commented Jan 24, 2018

@fottavi, I fixed the AppVeyor build in your exceptionHandling branch. I had to remove the OpenSSL dependency and update to VS2017.

@fottavi fottavi merged commit 0ef3d9e into master Jan 25, 2018
@fottavi fottavi deleted the exceptionHandling branch January 25, 2018 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants