Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable docker IPv6 #800

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Enable docker IPv6 #800

merged 1 commit into from
Mar 11, 2020

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Mar 11, 2020

Enable IPv6 in docker so it can be used to test IPv6 with kind

xref: istio/istio#1756

@aojea aojea requested a review from a team as a code owner March 11, 2020 11:14
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 11, 2020
@istio-policy-bot
Copy link

😊 Welcome @aojea! This is either your first contribution to the Istio tools repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 11, 2020
@aojea
Copy link
Contributor Author

aojea commented Mar 11, 2020

/cc @howardjohn

@istio-testing
Copy link
Contributor

Hi @aojea. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea aojea mentioned this pull request Mar 11, 2020
Merged
2 tasks
howardjohn
howardjohn approved these changes Mar 11, 2020
View reviewed changes
docker/build-tools/prow-entrypoint.sh
# optionally enable ipv6 docker
export DOCKER_IN_DOCKER_IPV6_ENABLED=${DOCKER_IN_DOCKER_IPV6_ENABLED:-false}
if [[ "${DOCKER_IN_DOCKER_IPV6_ENABLED}" == "true" ]]; then
echo "wrapper.sh] [SETUP] Enabling IPv6 in Docker config ..."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this isn't wrapper.sh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups

@howardjohn
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Mar 11, 2020
@istio-testing istio-testing merged commit 8a32dc2 into istio:master Mar 11, 2020
Shuanglu pushed a commit to Shuanglu/istio-tools that referenced this pull request Jun 30, 2022
@aojea
Enable docker IPv6 (istio#800)
18de1f1
Shuanglu pushed a commit to Shuanglu/istio-tools that referenced this pull request Jul 6, 2022
@aojea
Enable docker IPv6 (istio#800)
fc995b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aojea @istio-policy-bot @istio-testing @howardjohn @googlebot