Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mcp specific test #1077

Merged
merged 4 commits into from
Dec 4, 2018
Merged

Remove mcp specific test #1077

merged 4 commits into from
Dec 4, 2018

Conversation

ayj
Copy link
Contributor

@ayj ayj commented Dec 1, 2018

Depends on istio/istio#10222 being merged first.

@ayj ayj added the do-not-merge/hold Block automatic merging of a PR. label Dec 1, 2018
@ayj ayj requested a review from hklai December 1, 2018 00:09
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Dec 1, 2018
@ayj ayj mentioned this pull request Dec 1, 2018
Merged
@ayj
Copy link
Contributor Author

ayj commented Dec 3, 2018

@hklai, non-MCP tests have been removed from presubmit

@ayj ayj removed the do-not-merge/hold Block automatic merging of a PR. label Dec 3, 2018
hklai
hklai reviewed Dec 3, 2018
View reviewed changes
prow/config.yaml Outdated
- "ci/circleci: e2e-pilot-noauth-v1alpha3-v2"
- "ci/circleci: e2e-mixer-noauth-v1alpha3-v2"
- "ci/circleci: e2e-pilot-cloudfoundry-v1alpha3-v2"
- "ci/circleci: e2e-mixer-noauth-v1alpha3-v2-non-mcp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is istio/istio#10222 in master already?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet (see istio/istio#10256).

hklai
hklai approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@hklai hklai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayj, hklai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit c1cfb6d into istio:master Dec 4, 2018
@istio-testing
Copy link
Collaborator

@ayj: Updated the following 2 configmaps:

  • job-config configmap using the following files:
    • key istio.istio.release-1.1.yaml using file prow/cluster/jobs/istio/istio/istio.istio.release-1.1.yaml
    • key istio.istio.master.yaml using file prow/cluster/jobs/istio/istio/istio.istio.master.yaml
  • config configmap using the following files:
    • key config.yaml using file prow/config.yaml

In response to this:

Depends on istio/istio#10222 being merged first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hklai hklai hklai approved these changes

@rkpagadala rkpagadala Awaiting requested review from rkpagadala

@sebastienvas sebastienvas Awaiting requested review from sebastienvas

Assignees

@hklai hklai

Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayj @istio-testing @hklai @googlebot