Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update common file, including license #2630

Merged
merged 2 commits into from
Jan 24, 2020
Merged

Update common file, including license #2630

merged 2 commits into from
Jan 24, 2020

Conversation

bianpengyuan
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@bianpengyuan bianpengyuan requested a review from a team January 23, 2020 18:18
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 23, 2020
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 23, 2020
@bianpengyuan
Copy link
Contributor Author

bianpengyuan commented Jan 24, 2020 •
edited
Loading

@PiotrSikora @howardjohn Any idea who manages circleci account now? Looks like it might be our macos subscription expires.

@PiotrSikora
Copy link
Contributor

I have no idea, sorry.

@howardjohn
Copy link
Member

I think its @duderino

@bianpengyuan
Copy link
Contributor Author

I created a istio/test-infra#2298 to make macos test non-required temporarily to unblock PRs. @duderino Would you mind to help to set up the macos plan correctly?

@bianpengyuan
Copy link
Contributor Author

/retest

@bianpengyuan bianpengyuan reopened this Jan 24, 2020
@bianpengyuan
Copy link
Contributor Author

Hmm.. Do I need to recreate the pr to make circleci non-required?

@bianpengyuan
Copy link
Contributor Author

@clarketm ^^^

@howardjohn
Copy link
Member

I think there is some delay, it may run every 30min or something? I just did the same thing

@clarketm
Copy link
Member

clarketm commented Jan 24, 2020 •
edited
Loading

Hmm.. Do I need to recreate the pr to make circleci non-required?

Looks like the branchprotector is configured to run at 54 past the hour every hour (ref). I triggered a rerun on the job (should pick up the change after the job completes). Would be nice if this was a postsubmit, responding to changes to the config so it is immediate.

@clarketm clarketm mentioned this pull request Jan 24, 2020
Open
@bianpengyuan
Copy link
Contributor Author

@kyessenov @PiotrSikora ptal, thanks!

@istio-testing istio-testing merged commit e3bd8a1 into istio:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrSikora PiotrSikora PiotrSikora approved these changes

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
6 participants
@bianpengyuan @PiotrSikora @howardjohn @clarketm @googlebot @istio-testing