Improvements to ProxyProtocol testing and implementation #51769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add PROXY support to Echo. This avoids the need to spin up a whole new gateway deployment just for one test. * Use the new support to make our PROXY test simpler. Now its just "apply DR; send traffic" * This exposed a bug in the implementation; fixed that The original motivation for this is I am expanding testing of PROXY in another PR (wrt to waypoints).
howardjohn
added
the
release-notes-none
istio-testing
added
the
size/L
howardjohn
changed the title
keithmattix
approved these changes
Jun 27, 2024
howardjohn
force-pushed
the
test/echo-proxy-protocol
branch
from
c83a228
to
2098efb
Compare
hzxuzhonghu
reviewed
Jun 28, 2024
| @@ -472,6 +473,19 @@ func (cb *ClusterBuilder) applyUpstreamProxyProtocol( | |||
| return | |||
| } | |||
| c := opts.mutable | |||
|
|
|||
| // No existing transport; wrap RawBuffer. | |||
| if c.cluster.TransportSocket == nil && len(c.cluster.TransportSocketMatches) == 0 { | |||
There was a problem hiding this comment.
How could this happend, either TransportSocket or TransportSocketMatches is set before calling this function
There was a problem hiding this comment.
Not if tls is disabled, then there is neither
There was a problem hiding this comment.
There is a unit test case covering this
There was a problem hiding this comment.
and the new integration test also covers this
|
/retest |
hzxuzhonghu
approved these changes
Jun 28, 2024
|
/test integ-ambient-ipv6_istio |
dhawton
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gateway deployment just for one test.
"apply DR; send traffic"
The original motivation for this is I am expanding testing of PROXY in
another PR (wrt to waypoints).
This needed some changes to avoid re-using the TransportSocket for HBONE, which results in mutating shared state. this is broken today in a fatal way, its just not tested enough to trigger it until now.