Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align the labels in the pull request tpl to the issue's #51641

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

spacewander
Copy link
Contributor

@spacewander spacewander commented Jun 20, 2024

Please provide a description of this PR:

In #51640, I wanted to use the same label as #51639 ("extensions and telemetry") but didn't find one.

@istio-policy-bot istio-policy-bot added area/test and release release-notes-none Indicates a PR that does not require release notes. labels Jun 20, 2024
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Jun 20, 2024
@istio-testing
Copy link
Collaborator

Hi @spacewander. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zirain
Copy link
Member

zirain commented Jun 20, 2024

is this need align with prow bot config.

@spacewander
Copy link
Contributor Author

@zirain
Would you point it out where is the prow bot configuration for the labels? Thanks!

Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think this needs corresponding changes on

../bots/policybot/config/boilerplates/pr-area-selection.yaml
13:  - \[[ \w]\] +Policies and Telemetry

../bots/policybot/config/autolabels/policies-and-telemetry.yaml
1:name: Policies and Telemetry

../bots/policybot/handlers/githubwebhook/cleaner/testdata/pr-default.txt
14:- [ ] Policies and Telemetry

in istio/bots

spacewander added a commit to spacewander/bots that referenced this pull request Jun 22, 2024
According to istio/istio#51641
Signed-off-by: spacewander <[email protected]>
@spacewander
Copy link
Contributor Author

@howardjohn
Thanks for pointing it out. Updated in istio/bots#845.

istio-testing pushed a commit to istio/bots that referenced this pull request Jun 24, 2024
According to istio/istio#51641
Signed-off-by: spacewander <[email protected]>
@howardjohn
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jun 24, 2024
@istio-testing istio-testing merged commit cc059c4 into istio:master Jun 24, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test and release ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants