WIP: loading certs with tls.crt improvements #51475
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also includes a more convenient way to deploy ztunnel selectively on nodes based on a 'ztunnel' label - this is very useful for canary and testing. Can be achieved by using 'affinity' - if controversial I'll keep just affinity, if not I'll add the docs for the option (and make a similar change to istio-cni)
hzxuzhonghu
reviewed
Jun 11, 2024
|
|
||
| The code path for file-based certificate loading can also handle multiple roots and changing the root CA. The process is relatively complex - since rotations are not frequent, restarting istiod can be acceptable. | ||
|
|
||
| The file path - and the casecrets Secret - should be used with the standard K8S and CertManager naming conventions: |
hzxuzhonghu
reviewed
Jun 11, 2024
|
|
||
| CA has many options, depending on the security requirements and the existing environment of the user. From easiest to most secure: | ||
|
|
||
| 1. Simplest: use the default istio-ca-secret. Append roots to the root-cert.pem key to support extra roots or for rotations. Doesn't work well with multiple clusters, but best for dev/testing. It is possible to use a tool to patch the root-cert.pem in each cluster with the merged roots - but if you have automation better use (2). |
There was a problem hiding this comment.
istio-ca-secret is not maintained by user, how can we append extra roots for rotations
hzxuzhonghu
reviewed
Jun 11, 2024
|
|
||
| ## Istiod with external DNS certs | ||
|
|
||
| Default is for Istiod to sign its own certificate, but volume mounts are also possible, using istio-tls and |
| @@ -236,6 +236,8 @@ spec: | |||
| expirationSeconds: 43200 | |||
| path: istio-token | |||
| # Optional: user-generated root | |||
| # TODO: option to remove this mount - and use Secret directly. | |||
|
@costinm: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2024-06-11. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions. Created by the issue and PR lifecycle manager. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
This is WIP for fixing the tls.crt and adding more info about the chains - to get early feedback and
see if I'm missunderstanding something.