Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fuzzing for OpenAPI/CEL vs Webhook validation #51287

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Fuzzing for OpenAPI/CEL vs Webhook validation #51287

merged 2 commits into from
Jun 27, 2024

Conversation

howardjohn
Copy link
Member

This tests + fuzzes that our CEL validation is equivilent to our
webhook. This ensures we are not introducing breaking changes (too much
or too little) validation in CEL.

@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label May 29, 2024
@istio-testing
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 29, 2024
@howardjohn howardjohn mentioned this pull request May 29, 2024
Merged
@howardjohn howardjohn marked this pull request as ready for review May 30, 2024 14:44
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label May 30, 2024
@howardjohn howardjohn mentioned this pull request May 31, 2024
Merged
@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR needs to be rebased before being merged and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR needs to be rebased before being merged labels May 31, 2024
@howardjohn
Fuzzing for OpenAPI/CEL vs Webhook validation
e42446d 
This tests + fuzzes that our CEL validation is equivilent to our
webhook. This ensures we are not introducing breaking changes (too much
or too little) validation in CEL.
@howardjohn
Copy link
Member Author

cc @keithmattix

@howardjohn
Copy link
Member Author

@linsun can you take a look?

@howardjohn
Copy link
Member Author

/retest

@istio-testing istio-testing merged commit e3386b4 into istio:master Jun 27, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithmattix keithmattix keithmattix approved these changes

@stevenctl stevenctl stevenctl approved these changes

@costinm costinm Awaiting requested review from costinm costinm is a code owner

@linsun linsun Awaiting requested review from linsun linsun is a code owner

@ericvn ericvn Awaiting requested review from ericvn ericvn is a code owner

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu hzxuzhonghu is a code owner

Assignees

@stevenctl stevenctl

Labels
release-notes-none Indicates a PR that does not require release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@howardjohn @istio-testing @keithmattix @stevenctl @linsun @whitneygriffith @jaellio