Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gatewayapi: fix buildHTTPVirtualServices match order #51231

Closed
wants to merge 1 commit into from
Closed

gatewayapi: fix buildHTTPVirtualServices match order #51231

wants to merge 1 commit into from

Conversation

zirain
Copy link
Member

@zirain zirain commented May 24, 2024 •
edited
Loading

Please provide a description of this PR:

fixes: #50108

resubmit #50109

@zirain zirain requested review from a team as code owners May 24, 2024 07:39
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 24, 2024
@howardjohn
Copy link
Member

What has changed from the first time? Can you give some context?

@zirain
Copy link
Member Author

zirain commented May 24, 2024

What has changed from the first time? Can you give some context?

nothing was changing, I cannot reuse last PR because of rebase/force push, you should put a request change to hold this first.

@howardjohn howardjohn added the do-not-merge/hold Block automatic merging of a PR. label May 24, 2024
@istio-policy-bot
Copy link

🧭 This issue or pull request has been automatically marked as stale because it has not had activity from an Istio team member since 2024-05-24. It will be closed on 2024-07-08 unless an Istio team member takes action. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Jun 24, 2024
@zirain
Copy link
Member Author

zirain commented Jun 24, 2024

Thanks @howardjohn for explain the API spec, let me close this first.

TBH, I'm not sure is it a good idea to change the match order from Exact/Prefix/Regex to Exact/Regex/Prefix.

@zirain zirain closed this Jun 24, 2024
@zirain zirain deleted the gatewayapi-match-order branch June 24, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/hold Block automatic merging of a PR. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gatewayapi: match rule was ignored
4 participants
@zirain @howardjohn @istio-policy-bot @istio-testing