Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import common files into this repo. #14473

Merged
merged 2 commits into from
Jun 1, 2019
Merged

Import common files into this repo. #14473

merged 2 commits into from
Jun 1, 2019

Conversation

geeknoid
Copy link
Contributor

@geeknoid geeknoid commented May 31, 2019

  • Delete unused cruft.

  • Add a bunch of missing copyright messages discovered by the
    fixed linter license checker.

Copy link
Member

@sdake sdake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good minus the change to the license file.

LICENSE Outdated Show resolved Hide resolved
@geeknoid
Copy link
Contributor Author

/test e2e-simpleTests-master

@geeknoid geeknoid requested a review from howardjohn May 31, 2019 12:08
mtail added 2 commits May 31, 2019 12:45
- Delete some unused cruft.

- Add missing copyright notices detected by fixed license checking linter.
These categories will be used to automatically apply area labels to
incoming issues.
Copy link
Member

@linsun linsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@istio-testing
Copy link
Collaborator

@linsun: changing LGTM is restricted to assignees, and assigning you to the PR failed.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geeknoid, linsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linsun linsun added the lgtm label May 31, 2019
@istio-testing istio-testing merged commit b760e61 into istio:master Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants