Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.22 periodic base updater broken #51425

Closed
howardjohn opened this issue Jun 5, 2024 · 0 comments · Fixed by istio/release-builder#1867
Closed

1.22 periodic base updater broken #51425

howardjohn opened this issue Jun 5, 2024 · 0 comments · Fixed by istio/release-builder#1867
Labels
area/test and release

Comments

@howardjohn
Copy link
Member

https://prow.istio.io/view/gs/istio-prow/logs/build-base-images_release-builder_release-1.22_periodic/1797342614861647872

No apko. but that sohuld only be used for master?
howardjohn added a commit to howardjohn/istio-release that referenced this issue Jun 5, 2024
@howardjohn
Fix versioning issues
b2fe2c6 
Fixes istio/istio#51425
Fixes istio/istio#51348

Two issues:
* client-go always builds from HEAD of branch instead of where go.mod
  actually points
* Base image always uses master instead of branched
@howardjohn howardjohn mentioned this issue Jun 5, 2024
Merged
howardjohn added a commit to howardjohn/istio-release that referenced this issue Jun 5, 2024
@howardjohn
Fix versioning issues
0fb5e7b 
Fixes istio/istio#51425
Fixes istio/istio#51348

Two issues:
* client-go always builds from HEAD of branch instead of where go.mod
  actually points
* Base image always uses master instead of branched
istio-testing pushed a commit to istio/release-builder that referenced this issue Jun 5, 2024
@howardjohn
Fix versioning issues (#1867)
32d4735 
Fixes istio/istio#51425
Fixes istio/istio#51348

Two issues:
* client-go always builds from HEAD of branch instead of where go.mod
  actually points
* Base image always uses master instead of branched
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/test and release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix versioning issues howardjohn/istio-release
1 participant
@howardjohn