Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add XDS benchmarks for ambient #42315

Closed
howardjohn opened this issue Dec 6, 2022 · 2 comments · Fixed by #53062
Closed

Add XDS benchmarks for ambient #42315

howardjohn opened this issue Dec 6, 2022 · 2 comments · Fixed by #53062
Assignees
@howardjohn
Labels
area/ambient Issues related to ambient mesh lifecycle/staleproof Indicates a PR or issue has been deemed to be immune from becoming stale and/or automatically closed

Comments

@howardjohn
Copy link
Member

pilot/pkg/xds/bench_test.go has benchmark tests for XDS generation. These are important tests to track control plane
performance (and data plane, to some extent).

We should add tests for both waypoints and ztunnels.

size: S, type: implementation
@howardjohn howardjohn added the area/ambient Issues related to ambient mesh label Dec 6, 2022
@howardjohn
Copy link
Member Author

This is fairly non-trivial until we impleented support for ServiceEntry since the benchmarks assume istio config

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label May 16, 2023
@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label May 31, 2023
@hanxiaop hanxiaop added the lifecycle/staleproof Indicates a PR or issue has been deemed to be immune from becoming stale and/or automatically closed label May 31, 2023
@hanxiaop
Copy link
Member

not stale

@hanxiaop hanxiaop reopened this May 31, 2023
@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label May 31, 2023
@hanxiaop hanxiaop removed the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label May 31, 2023
@howardjohn howardjohn removed the P1 label Jul 18, 2023
@howardjohn howardjohn self-assigned this Sep 9, 2024
howardjohn added a commit to howardjohn/istio that referenced this issue Sep 9, 2024
@howardjohn
xds benchmarks for waypoint
eab5eb4 
Fixes istio#42315. A few structural
changes to the tet setup needed to make this work
@howardjohn howardjohn mentioned this issue Sep 9, 2024
Merged
howardjohn added a commit to howardjohn/istio that referenced this issue Sep 9, 2024
@howardjohn
xds benchmarks for waypoint
adaea63 
Fixes istio#42315. A few structural
changes to the tet setup needed to make this work
howardjohn added a commit to howardjohn/istio that referenced this issue Sep 12, 2024
@howardjohn
xds benchmarks for waypoint
b0adc96 
Fixes istio#42315. A few structural
changes to the tet setup needed to make this work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@howardjohn howardjohn

Labels
area/ambient Issues related to ambient mesh lifecycle/staleproof Indicates a PR or issue has been deemed to be immune from becoming stale and/or automatically closed
Projects
Ambient tracking
Status: Done
Ambient project tracking
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xds benchmarks for waypoint howardjohn/istio
4 participants
@howardjohn @hanxiaop @istio-policy-bot @SkyfireFrancisZ