Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: minor correction #947

Merged
merged 2 commits into from
Jun 16, 2019
Merged

docs: minor correction #947

merged 2 commits into from
Jun 16, 2019

Conversation

ramaraochavali
Copy link
Contributor

No description provided.

@ramaraochavali
minor doc fix
aee2e04 
Signed-off-by: Rama Chavali <[email protected]>
@ramaraochavali
generated docs
f6d4835 
Signed-off-by: Rama Chavali <[email protected]>
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jun 15, 2019
@istio-testing
Copy link
Collaborator

Hi @ramaraochavali. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rshriram
rshriram approved these changes Jun 16, 2019
View reviewed changes
Copy link
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jun 16, 2019
@rshriram
Copy link
Member

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramaraochavali, rshriram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 8d15f12 into istio:master Jun 16, 2019
@ramaraochavali ramaraochavali deleted the fix/docs branch June 17, 2019 02:59
nacx pushed a commit to nacx/api that referenced this pull request Apr 15, 2020
@tetrate-ci
In memory db in mock (istio#947)
96dfc3a 
* api tweaks

* in mem impl for mocks

* another tweak

* rudimentary rest api implementation

Signed-off-by: Shriram Rajagopalan <[email protected]>

* fixes

Signed-off-by: Shriram Rajagopalan <[email protected]>

* lint

Signed-off-by: Shriram Rajagopalan <[email protected]>

Mirrored from https://github.com/tetrateio/tetrate @ ca7c03ea143813886885cfdd168c2e364facf2da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rshriram rshriram rshriram approved these changes

@frankbu frankbu Awaiting requested review from frankbu

Assignees

@rshriram rshriram

Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ramaraochavali @istio-testing @rshriram @googlebot