Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing envoy_google_grpc with envoy_grpc for als #937

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

hanahmily
Copy link
Contributor

This change is in preparation for adding support for the envoy http gRPC access log service (ALS) API. The old solution is using envoy_google_grpc which is not quite stable, so I change it to envoy_grpc.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jun 4, 2019
@istio-testing
Copy link
Collaborator

Hi @hanahmily. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rshriram
Copy link
Member

rshriram commented Jun 4, 2019

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jun 4, 2019
@rshriram
Copy link
Member

rshriram commented Jun 4, 2019

thanks for fixing this. ! @douglas-reid / @mandarjog - this is now consistent with envoy metrics service

@rshriram
Copy link
Member

rshriram commented Jun 4, 2019

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hanahmily, rshriram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 6f137ab into istio:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants