Add ingress service to the proxy mesh #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rshriram
approved these changes
Apr 26, 2017
kyessenov
reviewed
Apr 26, 2017
proxy/v1/config/cfg.proto
Outdated
| @@ -133,6 +133,9 @@ message ProxyMeshConfig { | |||
|
|
|||
| // Path to the secrets used by the authentication policy | |||
| string auth_certs_path = 101; | |||
|
|
|||
| // Optional service fronting the ingress controllers | |||
There was a problem hiding this comment.
You can drop "optional" since everything is optional in this file. Maybe move it closer to egress or ingress settings? You can renumber the fields since we don't need to keep wire format same.
kyessenov
approved these changes
Apr 26, 2017
incfly
pushed a commit
to incfly/api
that referenced
this pull request
Jun 13, 2018
* use new api. * main code change. * Rename CacheState to CacheResult * update to latest api change. * Rename CacheResult to CheckResult.
nacx
pushed a commit
to nacx/api
that referenced
this pull request
Feb 23, 2022
Signed-off-by: Gao Hongtao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for ingress to expose its external IP. See: istio/old_pilot_repo#562