Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields to allow min/max TLS version and supported cipher suites #645

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

ijsnellf
Copy link
Contributor

@ijsnellf ijsnellf commented Oct 2, 2018

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 2, 2018
@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: andraxylia

If they are not already assigned, you can assign the PR to them by writing /assign @andraxylia in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ijsnellf
Copy link
Contributor Author

ijsnellf commented Oct 2, 2018

/assign @rshriram @frankbu @costinm @myidpt

@istio-testing
Copy link
Collaborator

@ijsnellf: GitHub didn't allow me to assign the following users: myidpt.

Note that only istio members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @rshriram @frankbu @costinm @myidpt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rshriram rshriram merged commit 63c5c77 into istio:master Oct 2, 2018
@ijsnellf ijsnellf deleted the tls-require-version branch October 2, 2018 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants