Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for LightStep tracing to ProxyConfig #638

Merged
merged 6 commits into from
Oct 5, 2018

Conversation

JulianGriggs
Copy link
Contributor

This PR adds configuration for a LightStep tracing backend to the ProxyConfig proto.

A WIP/POC implementation can be found here. When this PR gets finalized I will update and submit the implementation for review.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: diemtvu

If they are not already assigned, you can assign the PR to them by writing /assign @diemtvu in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Sep 25, 2018
@JulianGriggs
Copy link
Contributor Author

I signed it!

Copy link
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! It would be good to consolidate the tracing config so that we pave the way for other tracers as well.


// Configuration for a LightStep tracing backend (optional). If set, it will
// take precedence over [zipkinAddress][istio.mesh.v1alpha1.ProxyConfig.zipkin_address].
LightstepCollector lightstep_collector = 19;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark the zipkin address as deprecated. And create a tracing message that is a one-of between Zipkin/lightstep. something like

message Tracing {
 message Zipkin {
   address string
 }
 message LightStep {
  ...
 }
  one_of {
    Zipkin zipkin;
    Lightstep lightstep;
 }
}
Tracing tracing

The proxyconfig is internal data structure. We formalized it here for some documentation purposes. So, there is no backward compatibility issues here. It merely translates to the set of CLI args that we pass to the pilot agent [which you will have to update anyway to enable lightstep].

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Oct 2, 2018
@JulianGriggs
Copy link
Contributor Author

@rshriram Thanks for the review! I created a consolidated Tracing message as you described. Question: do you think it should be a top-level message or should it be nested within ProxyConfig? I currently have it as a top level message but am happy to change it if you think it would be better off nested.

@JulianGriggs
Copy link
Contributor Author

/assign @rshriram

@JulianGriggs
Copy link
Contributor Author

pinging @frankbu @hklai @rshriram for review :)

Copy link
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I hope you also have a PR in istio/istio for this?

@rshriram
Copy link
Member

rshriram commented Oct 5, 2018

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants