-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added headers manipulations capabilities to DestinationWeight #626
Conversation
…nse_headers and append_response_headers.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
This PR is needed for istio PR: |
I signed it! |
/ok-to-test |
Hi. Soprry for the delay. I can't merge this until the CLA thing is set.. can you take care of the CLA and ping me again? |
Thanks for the test. Can you take care of the CLA please? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rshriram The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@omersadika which identity did you use the sign the CLA ? I cannot find you in the database. |
I signed as a company, the name is Bevyx |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
Bevyx Inc has signed the agreement |
Thank you a lot @sebastienvas and @rshriram What about the PR in Istio repo? |
@omersadika @frankbu pointed out an important fact. This destination weight is shared across tcp and other future protos. Instead of having append_headers, etc.. can you create a separate sub message in DestinationWeight, like http:.. within which, you can stick in any thing you want (append_headers, remove.., etc.). This leaves the door for TCP and TLS to do some things in future.. Something like this:
Please rework the current structs accordingly. Sorry for not spotting this earlier. |
Really good point @rshriram |
A possibility is to add one new message, I'm also wondering why we need these headers fields in both the |
Sounds good. It makes sense to have it also in HTTPRoute if you want to add it to all destinations at once. Actually the way it's done today is deprecated in Envoy so I can also update to the new way, I will also check to add the other xxx_headers options for route. Do I have a green light to make the changes? |
Now that I think about it, Edit: Actually @rshriram WDYT? |
As long as this does not involve any changes in teh field names (for backward compatibility), I am okay with the renaming and adding the header operations under the destination weight. Also, please have an option for adding/removing both request and response headers (envoy has a PR in flight to remove request headers). |
added 3 new fields to DestinationWeight: append_headers, remove_response_headers and append_response_headers.