Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to IPv4 address 1.2.3.4 from proto #2774

Closed
tomari opened this issue May 2, 2023 · 1 comment · Fixed by #2777
Closed

Remove reference to IPv4 address 1.2.3.4 from proto #2774

tomari opened this issue May 2, 2023 · 1 comment · Fixed by #2777

Comments

@tomari
Copy link
Contributor

tomari commented May 2, 2023

Bug description

In following proto files there are references to an IPv4 address 1.2.3.4 .

  • security/v1/authorization_policy.proto
  • security/v1beta1/authorization_policy.proto

The IPv4 address currently belongs to APNIC Debogon Project, which means that it is currently unallocated but may be allocated in the future. For documentation purposes RFC5737 allocates 192.0.2.0/24 (TEST-NET-1), 198.51.100.0/24 (TEST-NET-2), and 203.0.113.0/24 (TEST-NET-3). Documentation in proto files should use one of these addresses instead.

Affected product area (please put an X in all that apply)

[ ] Configuration Infrastructure
[X] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
@howardjohn
Copy link
Member

Would accept a PR for this. Thanks for the issue!

tomari added a commit to tomari/istio-api that referenced this issue May 2, 2023
@tomari
Replace 1.2.3.4 with RFC5737 address (istio#2774)
f04755d
@tomari tomari mentioned this issue May 2, 2023
Merged
istio-testing pushed a commit that referenced this issue May 3, 2023
@tomari
Replace 1.2.3.4 with RFC5737 address (#2774) (#2777)
c899271
istio-testing pushed a commit to istio-testing/api that referenced this issue May 3, 2023
@tomari @istio-testing
Replace 1.2.3.4 with RFC5737 address (istio#2774)
a624201
istio-testing added a commit that referenced this issue May 3, 2023
@istio-testing @tomari
Replace 1.2.3.4 with RFC5737 address (#2774) (#2778)
c30879c 
Co-authored-by: Hisanobu Tomari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace 1.2.3.4 with RFC5737 address (#2774) tomari/istio-api
2 participants
@howardjohn @tomari