Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] useFetch hook 개선, IssueDetailBody 변경 사항 반영 #99

Merged
merged 5 commits into from
Aug 7, 2023
Merged

[FE] useFetch hook 개선, IssueDetailBody 변경 사항 반영 #99

merged 5 commits into from
Aug 7, 2023

Conversation

youzysu
Copy link
Member

@youzysu youzysu commented Aug 7, 2023 •
edited
Loading

Issues

What is this PR? 👓

  • useFetch hook 및 상태 관리 방식 개선

Key changes 🔑

  • useFetch 초기값 삭제
  • data, setData, isLoading, errorMessage 반환
  • 변경사항 type, API, mock data 반영

To reviewers 👋

  • IssueDetailHeader는 아직 모듈이 없어서 에러가 나서 일단 다 지웠어요.
  • IssueDetailBody의 assignee, label은 어차피 (array, set)가 달라서 별도의 state로 관리하는걸로 그대로 뒀어요.

Kakamotobi and others added 4 commits August 7, 2023 15:12
@youzysu youzysu added this to the [FE] Sprint #03 milestone Aug 7, 2023
@youzysu youzysu requested a review from Kakamotobi August 7, 2023 08:53
@youzysu youzysu changed the title [FE] useFetch hook 개선 [FE] useFetch hook 개선, IssueDetailPage 변경 사항 반영 Aug 7, 2023
@youzysu youzysu changed the title [FE] useFetch hook 개선, IssueDetailPage 변경 사항 반영 [FE] useFetch hook 개선, IssueDetailBody 변경 사항 반영 Aug 7, 2023
@Kakamotobi Kakamotobi merged commit 1ee021d into fe-w3 Aug 7, 2023
@Kakamotobi Kakamotobi deleted the fe/refactor/#94-use-fetch branch August 7, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kakamotobi Kakamotobi Kakamotobi approved these changes

Assignees

@Kakamotobi Kakamotobi

@youzysu youzysu

Labels
front-end
Projects
None yet
Milestone
[FE] Sprint #03
Development

Successfully merging this pull request may close these issues.
2 participants
@youzysu @Kakamotobi