[BE] 댓글 목록 조회 #82
Merged
[BE] 댓글 목록 조회 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
7 tasks
23Yong
approved these changes
Aug 4, 2023
tjdqls1200
approved these changes
Aug 4, 2023
| } | ||
| List<CommentsResponse> comments = commentRepository.findAll(issueId, cursor); | ||
| cursor = comments.get(comments.size() - 1).getId(); | ||
| boolean hasMore = commentRepository.hasMoreComment(issueId, cursor); |
There was a problem hiding this comment.
List의 size가 10 미만이면 hasMore이 false인 것을 알 수 있지 않을까요??
|
|
||
| @GetMapping | ||
| public ResponseEntity<Slice<CommentsResponse>> commentList(@PathVariable Integer issueId, | ||
| @RequestParam Integer cursor) { |
There was a problem hiding this comment.
개인적으로는 slice size를 SQL에서 고정하지않고 RequestParam으로(default 10) 줘도 좋을 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
What is this PR? 👓
댓글 목록 조회 기능에 대한 PR입니다.
Key changes 🔑
To reviewers 👋
커서 페이징 틀린게 없는지 확인해주세요!