[BE] Milestone API #77
Conversation
| @@ -88,4 +88,12 @@ public void updateIssueLabels(Integer issueId, IssueLabelRequest request) { | |||
| issueLabelRepository.deleteAll(toEntityList(request.getRemoveLabelsId(), | |||
| id -> new IssueLabel(issueId, id))); | |||
| } | |||
|
|
|||
| public void updateIssueMilestone(Integer issueId, Integer milestoneId) { | |||
There was a problem hiding this comment.
@Transactional ์ ๋
ธํ
์ด์
์ด ๋น ์ ธ์๋ค์!
| List<IssueDetailResponse.LabelInfo> labels = findLabelInfoById(issueId); | ||
| IssueDetailResponse.MilestoneInfo milestone = milestoneRepository.findMilestoneInfoByIssueId(issueId); | ||
| List<LabelResponse> labels = findLabelInfoById(issueId); | ||
| MilestoneResponse milestone = milestoneRepository.findMilestoneByIssueId(issueId); | ||
|
|
|
|
||
| @PostMapping("/{issueId}/milestone") | ||
| public void updateIssueMilestone(@PathVariable Integer issueId, | ||
| @RequestBody IssueMilestoneRequest milestoneRequest) { |
There was a problem hiding this comment.
์ด์ ์๋ ๋ชป๋ดค์๋๋ฐ ๋ฐํํ์
์ด void์ธ๋ฐ ResponseEntity<Void>๋ก ํตํฉํ๋ ๊ฑด ์ด๋ป๊ฒ ์๊ฐํ์๋์!
| @Getter | ||
| @NoArgsConstructor | ||
| public class IssueMilestoneRequest { | ||
| private Integer milestoneId; |
There was a problem hiding this comment.
ํ ์ค ๋์์ฃผ์ธ์ฉใ ใ
public class IssueMilestoneRequest {
private Integer milestoneId;|
|
||
| @DisplayName("ํน์ ์ด์์ ๋ง์ผ์คํค์ ์์ ํ ์ ์๋ค.") | ||
| @Test | ||
| public void updateIssueMilestone() { |
There was a problem hiding this comment.
JUnit5 ๋ถํฐ๋ ์ ๊ทผ์ ์ด์๋ฅผ public์ผ๋ก ์ํด๋ ํ
์คํธ๊ฐ ์ํ๋ฉ๋๋น!
void updateIssueMilestone() {
...
}https://junit.org/junit5/docs/snapshot/user-guide/#writing-tests-classes-and-methods
|
|
||
| MapSqlParameterSource params = new MapSqlParameterSource() | ||
| .addValue("milestoneId", milestoneId) | ||
| .addValue("issueId", issueId); |
There was a problem hiding this comment.
์ฌ๊ธฐ์ Map.of()๋ฅผ ์ฌ์ฉํ ๋milestoneIdํน์ issueId๊ฐ null์ด๋ฉด NPE๊ฐ ๋ฐ์ํ๋ค๋ ๊ฑด๊ฐ์?
| @@ -59,4 +60,10 @@ public void updateAssignees(@PathVariable Integer issueId, @RequestBody Assignee | |||
| public void updateIssueLabels(@PathVariable Integer issueId, @RequestBody IssueLabelRequest issueLabelRequest) { | |||
| issueService.updateIssueLabels(issueId, issueLabelRequest); | |||
| } | |||
|
|
|||
| @PostMapping("/{issueId}/milestone") | |||
There was a problem hiding this comment.
Notion API ๋ฌธ์์๋ PUT์ผ๋ก ๋์ด ์๋๋ฐ POST๋ก ๋ฐ๋๊ฑด๊ฐ์?
Issues
What is this PR? ๐
Key changes ๐
To reviewers ๐