[FE] 마일스톤 추가, 수정, 삭제 기능 및 기타 스타일 수정 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youzysu
changed the title
- 마일스톤 없을 때도 빈 아이템 보여주도록 수정 - openIssueCount, closedIssueCount number 타입으로 수정
Kakamotobi
requested changes
Aug 11, 2023
| <ul> | ||
| {milestoneList.map((milestone) => ( | ||
| {milestoneList?.map((milestone) => ( |
There was a problem hiding this comment.
위에서 check하는데 optional chaining은 불필요해보여요
There was a problem hiding this comment.
위에서 못걸러줘서 아래로 수정!
const hasMilestone = milestoneList && milestoneList.length !== 0;
return (
<TableBody>
{hasMilestone ? (
<ul>
{milestoneList.map((milestone) => (
Kakamotobi
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
What is this PR? 👓
Key changes 🔑
To reviewers 👋