[BE] 레이블 수정 기능 #120
Merged
[BE] 레이블 수정 기능 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23Yong
approved these changes
Aug 9, 2023
| @Transactional | ||
| public void modify(Integer labelId, String name, String description, String fontColor, String backgroundColor) { | ||
| Label label = new Label(labelId, name, description, fontColor, backgroundColor); | ||
| labelRepository.update(label); |
There was a problem hiding this comment.
음.. 저는 labelId가 존재하지 않는 경우에도 정상적으로 업데이트가 된것처럼 응답이 되는거 같아서 한번 체크해주는 것도 좋을 것 같습니다!
There was a problem hiding this comment.
확인해보니 mysql에서 labelId가 존재하지 않아도 에러가 발생하진 않는데 그래도 한번 더 체크할까요?!
| () -> assertThat(result.get(0).getLabelName()).isEqualTo("after"), | ||
| () -> assertThat(result.get(0).getFontColor()).isEqualTo("black"), | ||
| () -> assertThat(result.get(0).getBackgroundColor()).isEqualTo("1111")); | ||
|
|
tjdqls1200
approved these changes
Aug 10, 2023
| @Transactional | ||
| public void modify(Integer labelId, String name, String description, String fontColor, String backgroundColor) { | ||
| Label label = new Label(labelId, name, description, fontColor, backgroundColor); | ||
| labelRepository.update(label); |
There was a problem hiding this comment.
음.. 저는 labelId가 존재하지 않는 경우에도 정상적으로 업데이트가 된것처럼 응답이 되는거 같아서 한번 체크해주는 것도 좋을 것 같습니다!
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
What is this PR? 👓
레이블 수정 기능에 대한 PR입니다.
Key changes 🔑
To reviewers 👋
레이블 생성 기능에 fontColor를 frontColor로 작성했었네요 아무도 못찾은건 유머입니다.~ 깔깔
오타도 같이 봐주시면 감사하겠습니다 👍🏼