[BE] jwt principal 추가 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23Yong
approved these changes
Aug 8, 2023
| @@ -15,6 +17,8 @@ | |||
| @RequiredArgsConstructor | |||
| @Service | |||
| public class AuthService { | |||
| private static final String USER_ID = "userId"; | |||
There was a problem hiding this comment.
클래스와 필드 사이는 한 줄 띄어주세용~
public class AuthService {
private static final String USER_ID = "userId";| @AllArgsConstructor | ||
| @NoArgsConstructor | ||
| public class Principal { | ||
| private static final String USER_ID = "userId"; |
| @Builder | ||
| @AllArgsConstructor | ||
| @NoArgsConstructor | ||
| public class Principal { |
There was a problem hiding this comment.
정적 팩터리 메서드를 생성했는데 @AllArgsConstructor, @NoArgsConstructor를 달아주신 이유가 있나요?
There was a problem hiding this comment.
앗 수정하겠습니다! 감사합니다
pie2457
approved these changes
Aug 8, 2023
| @@ -15,6 +17,8 @@ | |||
| @RequiredArgsConstructor | |||
| @Service | |||
| public class AuthService { | |||
| private static final String USER_ID = "userId"; | |||
| private static final String LOGIN_ID = "loginId"; | |||
There was a problem hiding this comment.
요기 상수 처리는 앞으로를 위한건가요!? 지금은 한군데씩 밖에 사용을 안하는거죠?
There was a problem hiding this comment.
넵! 문자열은 보통 상수 처리하는 편입니다
There was a problem hiding this comment.
문자열이랑 상수 이름이 같아서 제거했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
What is this PR? 👓
Key changes 🔑
To reviewers 👋