Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify HTML copy command #3696

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Conversation

stotko
Copy link
Contributor

@stotko stotko commented Jul 6, 2021

The HTML copy command should update the resource directory on every build. However, the underlying logic is overly complicated and produces some noise, especially when the build is complete. Since add_custom_target is always out-dated by default, the simplified logic achieves the same result with less noise for the user.


This change is Reviewable

@stotko stotko requested a review from yxlao July 6, 2021 14:47
@update-docs
Copy link

update-docs bot commented Jul 6, 2021

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@yxlao yxlao merged commit 3ec7a19 into master Jul 7, 2021
@yxlao yxlao deleted the stotko/simplify-copy-html-command branch July 7, 2021 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants