Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console->Logger in pybind and unit test #3642

Merged
merged 3 commits into from
Jun 25, 2021
Merged

Console->Logger in pybind and unit test #3642

merged 3 commits into from
Jun 25, 2021

Conversation

yxlao
Copy link
Collaborator

@yxlao yxlao commented Jun 25, 2021 •
edited by germanros1987
Loading

This change is Reviewable

@yxlao yxlao requested a review from stotko June 25, 2021 07:50
@update-docs
Copy link

update-docs bot commented Jun 25, 2021

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

stotko
stotko approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@stotko stotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yxlao)

@yxlao yxlao merged commit 31a162d into master Jun 25, 2021
@yxlao yxlao deleted the yixing/console-to-logger branch June 25, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stotko stotko stotko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yxlao @stotko