Last batch of fixes from the Klocwork scan #3631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n Indexer::SplitLargestDim() I return nullptr if the two error conditions are true (there are two log messages early that do input validation In NumpyArray::Load I added an assert if fp is null after the fopen In NumpyArray::Save I return if fp is null after the fopen in BallPivotingVertexPtr FindCandidateVertex I assert if opp is a nullptr in io::WritePointCloud I return if fp is null after fopen
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
germanros1987
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
n Indexer::SplitLargestDim() I return nullptr if the two error conditions are true (there are two log messages early that do input validation
In NumpyArray::Load I added an assert if fp is null after the fopen
In NumpyArray::Save I return if fp is null after the fopen
in BallPivotingVertexPtr FindCandidateVertex I assert if opp is a nullptr
in io::WritePointCloud I return if fp is null after fopen
This change is