Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to C++17 in the future is currently blocked by third-party dependencies that rely on features that are removed in C++17. In particular, this affects
Flann
which makes use ofstd::random_shuffle
.Flann
bynanoflann
in legacygeometry::KDTreeFlann
classnanoflann
to 1.3.2 (required for col-major data access)nanoflann
submodule toExternalProject_Add
URL downloading approach to reduce dependency to git submodulesFlann
from3rdparty
Flann
as well as our legacy APIThis change is