Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted form positions #41

Closed
wants to merge 1 commit into from
Closed

Adjusted form positions #41

wants to merge 1 commit into from

Conversation

pastuh
Copy link

@pastuh pastuh commented Feb 2, 2023

No description provided.

@isekaidev
Copy link
Owner

  1. What is the point of adding a feature to hide prompts? A user needs them 90% of the time.

  2. What is the point of adding the generate button to one line with the seed? It is absolutely different controls and should be separated. Moreover, the CTA (Call-To-Action) buttons usually should be highlighted at the layer, it is weird when such button is located in the middle of the controls.

  3. Right now, the icon of the button for reusing a seed is similar to the same icon on the webui, changing it to just the text "seed" is much more unintuitive.

  4. Hardcoding a color of text is against Adobe guidelines because Photoshop has several color schemas (see the screenshot below).

  5. Adding "Advanced settings" to the top is unintuitive. The name itself means that it has no popular controls and will be used only by specific users. It will be much more logical when it is at the bottom. Also, adding the endpoint field to it will confuse new users.
    However, I agree that the endpoint could be hidden if a user has already set it. And I also agree that the model and sampler dropdowns could potentially be located in the advanced settings. But I have plans to entirely rework these parts, so for now, I prefer to leave them.

image

@isekaidev isekaidev closed this Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants