Minor fixes for LinearRegression example

is · Jun 13, 2014 · 8a55793 · 8a55793
1 parent 22949fc
commit 8a55793
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/...osphere-java-examples/src/main/java/eu/stratosphere/example/java/ml/LinearRegression.java b/...osphere-java-examples/src/main/java/eu/stratosphere/example/java/ml/LinearRegression.java
@@ -27,7 +27,7 @@
 import eu.stratosphere.example.java.ml.util.LinearRegressionData;
 
 /**
- * This example implements a basic Linear Regression using batch gradient descent algorithm.
+ * This example implements a basic Linear Regression  to solve the y = theta0 + theta1*x problem using batch gradient descent algorithm.
  *
  * <p>
  * Linear Regression with BGD(batch gradient descent) algorithm is an iterative clustering algorithm and works as follows:<br>
@@ -57,10 +57,6 @@
  * <li> Custom Java objects (PoJos)
  * </ul>
  */
-
-/**
- * A linearRegression example to solve the y = theta0 + theta1*x problem.
- */
 @SuppressWarnings("serial")
 public class LinearRegression {
 
@@ -100,7 +96,7 @@ public static void main(String[] args) throws Exception{
 
  // emit result
  if(fileOutput) {
- result.writeAsCsv(outputPath, "\n", " ");
+ result.writeAsText(outputPath);
  } else {
  result.print();
  }
@@ -150,7 +146,7 @@ public Params(double x0, double x1){
 
  @Override
  public String toString() {
- return "(" + theta0 + "|" + theta1 + ")";
+ return theta0 + " " + theta1;
  }
 
  public double getTheta0() {

diff --git a/...les/src/main/java/eu/stratosphere/example/java/ml/util/LinearRegressionDataGenerator.java b/...les/src/main/java/eu/stratosphere/example/java/ml/util/LinearRegressionDataGenerator.java
@@ -52,8 +52,6 @@ public class LinearRegressionDataGenerator {
  */
  public static void main(String[] args) throws IOException {
 
- System.out.println(args.length);
-
  // check parameter count
  if (args.length < 1) {
  System.out.println("LinearRegressionDataGenerator <numberOfDataPoints> [<seed>]");
@@ -69,7 +67,7 @@ public static void main(String[] args) throws IOException {
  // write the points out
  BufferedWriter pointsOut = null;
  try {
- pointsOut = new BufferedWriter(new FileWriter(new File(POINTS_FILE)));
+ pointsOut = new BufferedWriter(new FileWriter(new File(tmpDir+"/"+POINTS_FILE)));
  StringBuilder buffer = new StringBuilder();
 
  // DIMENSIONALITY + 1 means that the number of x(dimensionality) and target y