Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ah and esp protocals #775

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

support ah and esp protocals #775

wants to merge 2 commits into from

Conversation

kinglory
Copy link

support ah and esp protocals

esp_error:
proto_unregister(&dp_vs_proto_esp);
ah_error:
proto_unregister(&dp_vs_proto_ah);
return err;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please unregister protocols in the reverse order when error occurs. Note the label sequence.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I have fixed it. thank you.

&iph->saddr, &iph->daddr,
htons(PORT_ISAKMP), htons(PORT_ISAKMP),
direct, reverse);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to support connection redirection?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's logic for the first negotiation packages and the process is similar to the kernel ipvs code.

@ywc689
Copy link
Collaborator

ywc689 commented Dec 31, 2021

Does AE/ESP work with DPVS Fullnat?
Can you add an example to DPVS document to show how to use AE/ESP with DPVS?

@ywc689 ywc689 added the pr/codes-need-change problems found in the line-by-line code review and need to be fixed label Dec 31, 2021
@kinglory
Copy link
Author

kinglory commented Jan 4, 2022

Does AE/ESP work with DPVS Fullnat? Can you add an example to DPVS document to show how to use AE/ESP with DPVS?

I tested the code in the DR mode and it worked well when I use the ipsec protocal and I think it can work well in FullNat mode and Tunnel mode. It just helps the dpvs for more protocal support such as ah and esp. The use is totally the same. The users just need to configure the dpvs server in port 500(PORT_ISAKMP) and it can deal with the ipsec process logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/codes-need-change problems found in the line-by-line code review and need to be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants