Reduce the scope of IPIP-337 by excluding write operations #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the scope of IPIP-337 by temporarily excluding write operation. The write operations are to be added in a separate PR once the IPIP-337 is merged. See: - #337
Fix lint issues as reported by GitHub `super-liner`, including: - empty lines surrounding headers. - maximum line length. - unique headers - natural language. - tailing space.
fcb1a5c
to
9c47a31
Compare
lidel
reviewed
Jan 24, 2023
| } | ||
| ``` | ||
|
|
||
| - `Signature`: a multibase-encoded signature of the sha256 hash of the `Payload` field, signed using the private key of the Peer ID specified in the `Payload` JSON |
There was a problem hiding this comment.
Signature: a multibase-encoded signature of the sha256 hash of thePayloadfield, signed using the private key of the Peer ID specified in thePayloadJSON. Signing details for specific key types should follow libp2p/peerid specs, unless stated otherwise.
| - `ID` is the peer ID that was used to sign the record | ||
| - `Addrs` is a list of string-encoded multiaddrs | ||
|
|
||
| A 403 response code should be returned if the signature check fails. |
There was a problem hiding this comment.
A 400 Bad Request response code should be returned if the signature check fails.
masih
added a commit
that referenced
this pull request
Feb 13, 2023
Previous work reduced the scope of IPIP-337 to read operations only. The changes here re-introduce the write operations originally written by @guseggert back into IPIP-337. The specification documents the ability to provide Bitswap records over `PUT` requests with advisory TTL. An implementation of the specification is already present in go-libipfs. See: - #370
masih
added a commit
that referenced
this pull request
Feb 13, 2023
Previous work reduced the scope of IPIP-337 to read operations only. The changes here re-introduce the write operations originally written by @guseggert back into IPIP-337. The specification documents the ability to provide Bitswap records over `PUT` requests with advisory TTL. An implementation of the specification is already present in go-libipfs. See: - #370
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the scope of IPIP-337 by temporarily excluding write operation. The write operations are to be added in a separate PR once the IPIP-337 is merged.
See: