add env for logging to file and syslog #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frrist
added
the
kind/enhancement
ghost
added
the
frrist
changed the title
oldlog.go
Outdated
| if err != nil { | ||
| fmt.Printf("ERROR go-log: %s: failed to set logging file backend\n", err) | ||
| } | ||
| lgbe = append(lgbe, logging.NewLogBackend(f, "", 0)) |
There was a problem hiding this comment.
if the above errors, we don't want to add this backend. it will be to a bad file
Stebalien
reviewed
Sep 12, 2018
oldlog.go
Outdated
| if logfp := os.Getenv(envLoggingFile); len(logfp) > 0 { | ||
| f, err := os.Create(logfp) | ||
| if err != nil { | ||
| fmt.Printf("ERROR go-log: %s: failed to set logging file backend\n", err) |
There was a problem hiding this comment.
This should at least use stderr. Ideally, we'd log it but it may be too early for that.
There was a problem hiding this comment.
addressed - will write to stderr, I think it may be too early to log here.
frrist
force-pushed
the
feat/file-logging
branch
from
e956af0
to
29c2a5b
Compare
whyrusleeping
approved these changes
Sep 12, 2018
Stebalien
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this?
GOLOG_FILEGOLOG_SYSLOG_ENABLE