update JDK install instructions, fixes #366 #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
|
This should not have triggered a JAR rebuild, hmm. |
4bf7994
to
d8657a7
Compare
|
The JAR rebuild appears to be configured correctly: https://github.com/ipeaGIT/r5r/blob/master/.github/workflows/java-r5rcore-build.yaml#L6 It also seems like it has not run on commits that did not make java changes in the past, so maybe a transient Github issue? Anyways, I just force-pushed back to the previous commit, so this should be able to be merged now. |
|
thanks, Matt! Merging pr now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #366, make instructions for installing the JDK more clear and straightforward.