Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trace, tplist, argdist: UDST probe miscellaneous fixes #909

Merged
merged 5 commits into from
Jan 17, 2017
Merged

trace, tplist, argdist: UDST probe miscellaneous fixes #909

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
50486ff
tplist: Print one-based location and argument indices
goldshtn Jan 16, 2017
fd44cd2
argdist: Generated streq-helper to ignore null terminator
goldshtn Jan 16, 2017
b9aec34
trace: Generated streq-helper to ignore null terminator
goldshtn Jan 16, 2017
b630092
trace: Use correct argument index and tgid for filters
goldshtn Jan 16, 2017
dcf1675
trace, argdist: Fix code formatting nits
goldshtn Jan 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
trace, argdist: Fix code formatting nits
  • Loading branch information
@goldshtn
goldshtn committed Jan 17, 2017
commit dcf1675a744913212b04eae1a0dbebc552ad55db
2 changes: 1 addition & 1 deletion tools/argdist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ def _generate_streq_function(self, string):
char needle[] = %s;
char haystack[sizeof(needle)];
bpf_probe_read(&haystack, sizeof(haystack), (void *)str);
for (int i = 0; i < sizeof(needle)-1; ++i) {
for (int i = 0; i < sizeof(needle) - 1; ++i) {
if (needle[i] != haystack[i]) {
return false;
}
Expand Down
4 changes: 2 additions & 2 deletions tools/trace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ def _generate_streq_function(self, string):
char needle[] = %s;
char haystack[sizeof(needle)];
bpf_probe_read(&haystack, sizeof(haystack), (void *)str);
for (int i = 0; i < sizeof(needle)-1; ++i) {
for (int i = 0; i < sizeof(needle) - 1; ++i) {
if (needle[i] != haystack[i]) {
return false;
}
Expand Down Expand Up @@ -362,7 +362,7 @@ def _generate_usdt_filter_read(self):
continue
arg_index = int(arg.replace("arg", ""))
arg_ctype = self.usdt.get_probe_arg_ctype(
self.usdt_name, arg_index-1)
self.usdt_name, arg_index - 1)
if not arg_ctype:
self._bail("Unable to determine type of {} "
"in the filter".format(arg))
Expand Down