argdist, trace: Support non-C identifier names #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When argdist or trace face a function that has characters in its name that are not valid in C identifier, they now replace these characters with an underscore (`_`) when generating function names and structure names to include in the BPF program. As a result, it is now possible to trace functions that have these identifiers in their names, such as Golang functions like `fmt.Println`.
|
makes sense to me. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When argdist or trace face a function that has characters
in its name that are not valid in C identifiers, they now
replace these characters with an underscore (
_) whengenerating function names and structure names to include
in the BPF program. As a result, it is now possible to
trace functions that have these identifiers in their names,
such as Golang functions like
fmt.Println.Resolves #903 reported by @brendangregg.