Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trace: allow tracing of functions containing a dot (golang) #896

Merged
merged 1 commit into from
Jan 11, 2017
Merged

trace: allow tracing of functions containing a dot (golang) #896

merged 1 commit into from
Jan 11, 2017

Conversation

brendangregg
Copy link
Member

@brendangregg brendangregg commented Jan 11, 2017 •
edited
Loading

CC @goldshtn ; fixes #891

goldshtn
goldshtn approved these changes Jan 11, 2017
View reviewed changes
Copy link
Collaborator

@goldshtn goldshtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm still a bit worried that other runtimes might have other identifiers that won't be valid in C type names, but I guess we can fix them as we run into them...

@4ast 4ast merged commit ceb9089 into iovisor:master Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldshtn goldshtn goldshtn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trace to match functions containing a period (golang)
3 participants
@brendangregg @goldshtn @4ast