Fixes bio{snoop,top} on 4.10 #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ast
requested changes
Jan 7, 2017
| #else | ||
| if ((req->cmd_flags >> REQ_OP_SHIFT) == REQ_OP_WRITE) { | ||
| data.rwflag = !!(req->cmd_flags & REQ_OP_WRITE); |
There was a problem hiding this comment.
doesn't look right. It probably should be (req->cmd_flags & REQ_OP_MASK) == REQ_OP_WRITE
This commit fixes iovisor#888. The 2 scripts run the same check, and now run basically the same code to do it. Tested on 4.10-rc2.
01eec09
to
bc43a29
Compare
|
Thanks @4ast, updated. |
|
[buildbot, ok to test] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #888 by making sure
REQ_OP_SHIFT(removed in 4.10) is defined before evaluating, and adding code to handle 4.10's use ofREQ_OP_WRITE.biosnoop.pyandbiotop.pyboth check whether the op is a read or write, and now use more or less the same copy pasta code to do it.Tested on 4.10-rc2.