mysqld_slower: Fix breakage after USDT API change #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks; is this optional or required? Wondering if we need to change the examples/tracing and docs as well. |
|
It isn't optional, the constructor now takes an array. Yes, I haven't thought about the docs. Need to put this on my mental list of things to update when making API changes. |
|
@brendangregg: I updated the docs and examples to use the new API. |
A recent PR to the USDT infrastructure changed the BPF module constructor to accept an array of USDT contexts. This commit updates `mysqld_slower` to use that new constructor.
The BPF class constructor now accepts an array of USDT contexts instead of just one object. Update the examples in **examples/tracing** and docs in **docs** to reflect this change.
|
LGTM. buildbot, retest please |
|
[buildbot, test this please] |
|
[buildbot, add to whitelist] |
goldshtn
force-pushed
the
mysqld-slower-fix
branch
from
eec5926
to
a2370ab
Compare
|
Rebased to make this auto-mergeable. @brendangregg Can you please merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent PR to the USDT infrastructure changed the BPF
module constructor to accept an array of USDT contexts.
This commit updates
mysqld_slowerto use that newconstructor.