LuaJIT BPF compiler, examples, tests #652
Conversation
|
to the build bot: |
| Copyright (c) 2016, Marek Vavrusa <[email protected]> | ||
| All rights reserved. | ||
|
|
||
| Redistribution and use in source and binary forms, with or without |
There was a problem hiding this comment.
do you have a strong reason to choose bsd 2-clause license?
the rest of the bcc is covered by apache2 license.
the main reason we picked apache2 is patent rights.
There was a problem hiding this comment.
Not at all, happy to go with apache2. I'll remove the LICENSE file and update rockspec for the next iteration. Do you want a license header in each file or is it enough when it's covered by the LICENSE.txt ?
There was a problem hiding this comment.
all exported header files and examples have to have it. Single line like in tools/*.py would be enough though. Ideally all files... Just to avoid any ambiguity.
Pls squash and force push to have single commit for clean history.
Thanks!
vavrusa
force-pushed
the
master
branch
2 times, most recently
from
0a3b1f2
to
a9be447
Compare
|
The library now works with squishy, and examples work after installing 🙌 @vmg - the library depends on ljsyscall (which implements Next step is tests - right now it vendors luaunit. I'd like to bring in luacheck for static analysis, and luacov for code coverage. The luacov depends on unit test library support, so since there are not many tests I'd prefer to go with busted as a replacement for luaunit with support for code coverage. Other option is to not do static analysis and code coverage and rewrite my few tests to luaunit. Do you have any strong opinion on this? |
|
what is the status of this PR ? should it be rebased and merged? Any blockers? |
|
There is some duplication of the functionality (ljsyscall vs bcc.vendor.posix) and unit tests (busted vs luaunit), but that can be sorted out on the go. I've been on vacation for the past few weeks, and I'm coming back tomorrow, so I'll continue the work on it next week. |
vavrusa
changed the title
this is initial commit of LuaJIT bytecode to BPF compiler project that enables writing both kernel and user-part of the code as Lua
|
Rebased to latest master and updated the code. The imported tests now run with busted (if busted is found by CMake). |
|
looks great. thanks a lot! |
|
thanks! now the real work starts |
This is an initial commit of LuaJIT bytecode to BPF compiler project, that enables writing both kernel and user-part of the code in Lua.
It's by far complete, but very usable for socket filters, uprobes, kprobes, and tracepoints.
Compatibility checklist is in
src/lua/README.md. Most of the BPF map types are supported,complex types and arrays are supported with some limitations, most of the BPF helpers are supported.
examples/luamirroring similar examples written in C.TODO