libbpf-tools: enforce missing-field-initializers warning and error on… #4975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… warnings
In an internal build where `missing-field-initializers` would be enforce,
libbpf-tools would fail to build with an error similar to:
```
tcptop.c:75:9: error: missing initializer for field 'group' of 'const struct argp_option' [-Werror=missing-field-initializers]
75 | { "nosummary", 'S', NULL, 0, "Skip system summary line"},
| ^
In file included from tcptop.c:10:
/usr/include/argp.h:73:7: note: 'group' declared here
73 | int group;
| ^~~~~
```
This change tacks the default group value of 0 to all `struct argp_option` used
in libbpf-tools.
At the same time, I am taking the opportunity to promote warnings to error
in order to prevent regressions from making it in.
Signed-off-by: Manu Bretelle <[email protected]>
chantra
requested review from
drzaeus77,
goldshtn,
yonghong-song,
4ast,
brendangregg and
davemarchevsky
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… warnings
In an internal build where
missing-field-initializerswould be enforce, libbpf-tools would fail to build with an error similar to:This change tacks the default group value of 0 to all
struct argp_optionused in libbpf-tools.At the same time, I am taking the opportunity to promote warnings to error in order to prevent regressions from making it in.