Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes that enables bcc to build and work nicely on nixos:
add
-I/build/include/generated
when calculating cflags. This is whereautoconf.h
with#define CONFIG_BPF_SYSCALL 1
lives so it is critical. This appears to be true not only for nixos, but I checked Ubuntu 14.04.3 LTS too and the location was the same.bcc quite reasonably assumes that the kernel modules dir is
/lib/modules/
, encoded using#define KERNEL_MODULES_DIR "/lib/modules"
. This is not true for nixos however. The proposed patch:BCC_KERNEL_MODULES_DIR
cmake flag/lib/modules
, so no breaking changeKERNEL_MODULES_DIR
based on that flag.This allows us to override
KERNEL_MODULES_DIR
when building bcc for nixos.