Move cc/*py tests to python subdir and introduce c standalone test binary #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 3, 2016 15:39
They didn't quite make sense where they were. At one point 'cc' meant compiler, and yes they were testing the compiler. Now lets use the convention that different tests/ subdirectories test different bindings (c, python, other). Signed-off-by: Brenden Blanco <[email protected]>
This creates a new static library target for bcc. Add one trivial c test case that links against it. Signed-off-by: Brenden Blanco <[email protected]>
| set_target_properties(bcc-shared PROPERTIES VERSION ${REVISION_LAST} SOVERSION 0) | ||
| set_target_properties(bcc-shared PROPERTIES OUTPUT_NAME bcc) | ||
|
|
||
| add_library(bcc-loader-static libbpf.c perf_reader.c) |
There was a problem hiding this comment.
There's a dependency (bpf_map_create) required by both bcc and clang_frontend. This gets resolved at final link-time.
|
Buildbots failed, that's fixed now. |
4ast
added a commit
that referenced
this pull request
Mar 4, 2016
Move cc/*py tests to python subdir and introduce c standalone test binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the python tests to the python subdir. Adds a libbcc.a target for those statically inclined.